Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BaseGuildEmojiManager #4934

Merged
merged 4 commits into from
Nov 22, 2020
Merged

feat: BaseGuildEmojiManager #4934

merged 4 commits into from
Nov 22, 2020

Conversation

vaporoxx
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

[Continuing from #4917] This adds a new manager class BaseGuildEmojiManager to be used for Client#emojis, GuildEmojiManager then extends that to provide methods to interact with the API.

Status

  • Code changes have been tested against the Discord API
  • I know how to update typings and have done so

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

src/managers/BaseGuildEmojiManager.js Outdated Show resolved Hide resolved
@iCrawl iCrawl merged commit 8d650a7 into discordjs:master Nov 22, 2020
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants